mbs-octoml commented on code in PR #11481:
URL: https://github.com/apache/tvm/pull/11481#discussion_r890549382
##########
src/relay/op/dyn/tensor/transform.cc:
##########
@@ -258,6 +258,7 @@ RELAY_REGISTER_OP("dyn.broadcast_to")
.describe(R"code(Broadcast the first input to match the shape argument.
)code" TVM_ADD_FILELINE)
.set_num_inputs(2)
+ .set_attrs_type<InitOpAttrs>()
Review Comment:
no, needed since I include broadcast in my test relay text, and parsing
fails without it. (Another glitch I fix-as-I-go.)
##########
src/relay/ir/indexed_graph.h:
##########
@@ -19,7 +19,11 @@
/*!
* \file src/relay/ir/indexed_graph.h
- * \brief A pattern matcher for matching dataflow properties.
+ * \brief A graph representation of the dataflow in a Relay expression or
Relay dataflow
+ * pattern. Nodes in this graph capture generic dataflow inputs, outputs,
dominators and control
+ * flow scopes.
+ *
+ * TODO(mbs): Rename to 'DataflowGraph'.
Review Comment:
ack, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
