mbs-octoml commented on code in PR #11481:
URL: https://github.com/apache/tvm/pull/11481#discussion_r890559855


##########
tests/python/relay/test_dataflow_pattern.py:
##########
@@ -601,6 +600,64 @@ def test_match_fake_diamond():
     assert not diamond.match(out)
 
 
+def test_at_most_one_parent():

Review Comment:
   Ah, right. This test wast to confirm my understanding of the code, there's 
no harm leaving it even though it passes in main. The second test seems 
unnecessary so removed, sorry about that. None of these tests exercise the 
let-bound var dataflow changes in this PR since you can really only observe 
that at the lower IndexedGraph level. But the new c++ unit test does exercise 
all those changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to