apeskov commented on code in PR #11513:
URL: https://github.com/apache/tvm/pull/11513#discussion_r893236165
##########
src/relay/backend/contrib/dnnl/codegen.cc:
##########
@@ -507,6 +540,9 @@ class DNNLJSONSerializer : public
backend::contrib::JSONSerializer {
std::vector<std::string> op_list = ParsingOpList(name);
call = GetRootCall(fn->body.as<CallNode>(), op_list.size() - 1,
op_list);
ICHECK(call->op.as<OpNode>()) << "Not op node";
+ } else if (name.find("gelu") != std::string::npos) {
Review Comment:
I see. In context of this patch it's functionally correct. Just
counterintuitive `if` statement. Check if contain "gelu" and after that search
"dense". Without additional explanation it may make some engineers a slightly
confused.
So some additional comment line here would be great. Anyway that's is not
blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
