guberti commented on code in PR #11655:
URL: https://github.com/apache/tvm/pull/11655#discussion_r896185060
##########
apps/microtvm/reference-vm/zephyr/Vagrantfile:
##########
@@ -16,7 +16,8 @@
# under the License.
Vagrant.configure("2") do |config|
- config.vm.box = "tlcpack/microtvm-zephyr-2.7"
+ config.vm.box = "tlcpack/microtvm-zephyr"
+ config.vm.box_version = "0.5.0"
Review Comment:
I'm not a huge fan of the 2.7.X convention. For one, I don't think it's
clear where the Zephyr version part ends and the incremental number begins, and
it would be easy to believe e.g. 2.7.1 was a full version number.
Additionally, the Arduino VM won't have a relevant version number, so its
`box_version` is bound to be purely incremental. For consistency, we might want
to make the Zephyr `box_version` purely incremental as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
