areusch commented on code in PR #11655:
URL: https://github.com/apache/tvm/pull/11655#discussion_r899254498
##########
apps/microtvm/reference-vm/zephyr/Vagrantfile:
##########
@@ -16,7 +16,8 @@
# under the License.
Vagrant.configure("2") do |config|
- config.vm.box = "tlcpack/microtvm-zephyr-2.7"
+ config.vm.box = "tlcpack/microtvm-zephyr"
+ config.vm.box_version = "0.5.0"
Review Comment:
right, my apologies, i forgot @guberti and I discussed this concern a bit.
upon more reading, here's what I think:
- to some degree the version number of the box is an implementation detail
of that particular RVM.
- Vagrant is permissive in terms of what the box versioning can be, but
[strongly suggests](https://www.vagrantup.com/docs/boxes/versioning) semver
(see Version Constraints section)
- i think we should support semver with these boxes so that at least we
maintain some operational commonality between them
- we could probably directly map the Zephyr versions into the box's version
space if Zephyr does in fact support semver itself. I'm not so sure about that
and would need to google a bit more to find out. if not, perhaps we should then
rev the major version of the box each time we update Zephyr (or make any other
breaking change).
- for Arduino, let's make a decision along similar lines--my understanding
is that there isn't a singular version here, so we may have to be a bit more
explicit about documenting the versions of tools we care about so that the
community can rev the box revision appropriately.
thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
