junrushao1994 commented on code in PR #11692:
URL: https://github.com/apache/tvm/pull/11692#discussion_r897148428
##########
tests/python/unittest/test_meta_schedule_relay_tir_compute.py:
##########
@@ -147,8 +147,17 @@ def schedule_fn(task, sch):
return False
with TempOpAttr("nn.conv2d", "FTVMStrategy", _tmp_strategy):
- database = apply_fixed_schedules(relay_mod, target, params,
schedule_fn)
- with ApplyHistoryBest(database):
+ database = apply_fixed_schedules(
+ relay_mod,
+ target,
+ params,
+ schedule_fn,
+ te_filter_func="meta_schedule.DefaultTaskFilterAllowExtern",
Review Comment:
@csullivan there are a couple of options in my mind for us to unbreak MS's
current workflow with customer models:
- use `te_filter_func` when we want to specifically allow some `te.extern`
operation;
- use a different `te.extern_prim_func` to direct the default task filter to
accept them by default
- use annotations to instruct the default task filter instead
let me know what you think!
##########
tests/python/unittest/test_meta_schedule_relay_tir_compute.py:
##########
@@ -147,8 +147,17 @@ def schedule_fn(task, sch):
return False
with TempOpAttr("nn.conv2d", "FTVMStrategy", _tmp_strategy):
- database = apply_fixed_schedules(relay_mod, target, params,
schedule_fn)
- with ApplyHistoryBest(database):
+ database = apply_fixed_schedules(
+ relay_mod,
+ target,
+ params,
+ schedule_fn,
+ te_filter_func="meta_schedule.DefaultTaskFilterAllowExtern",
Review Comment:
@csullivan there are a couple of options in my mind for us to unbreak MS's
current workflow with customer models:
- use `te_filter_func` when we want to specifically allow some `te.extern`
operation;
- use a different `te.extern_prim_func` to direct the default task filter to
accept them by default
- use annotations to instruct the default task filter instead
let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
