csullivan commented on code in PR #11692:
URL: https://github.com/apache/tvm/pull/11692#discussion_r898130487
##########
tests/python/unittest/test_meta_schedule_relay_tir_compute.py:
##########
@@ -147,8 +147,17 @@ def schedule_fn(task, sch):
return False
with TempOpAttr("nn.conv2d", "FTVMStrategy", _tmp_strategy):
- database = apply_fixed_schedules(relay_mod, target, params,
schedule_fn)
- with ApplyHistoryBest(database):
+ database = apply_fixed_schedules(
+ relay_mod,
+ target,
+ params,
+ schedule_fn,
+ te_filter_func="meta_schedule.DefaultTaskFilterAllowExtern",
Review Comment:
@junrushao1994 thanks for the discussion! I think the approach you have
taken with a separate filter function is a good solution for now.
From the integration side I think it could indeed be desirable to separate
out the functionality into a new TE Op (your second option I believe) that can
be included by the default filter func so that it is transparent to end user.
But for now I think it's perfectly fine to approach it when the need arises.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
