AndrewZhaoLuo commented on PR #11712: URL: https://github.com/apache/tvm/pull/11712#issuecomment-1156755152
Certainly: https://github.com/apache/tvm/pull/11734. Now re: discussion on changing variable names. Right now we allow the following whitelist of 'bad' variable names: `i,j,_,a,b,op,x,y,wd,lr,kv,k,v,s,p,h,c,m,n,X,t,g,f` I think the new regexes are simply an extension of the status quo (as if we allow 'a' and 'b' as variable names we should also allow 'd') but in a more readable format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
