AndrewZhaoLuo commented on PR #11712: URL: https://github.com/apache/tvm/pull/11712#issuecomment-1157880427
> @AndrewZhaoLuo I suggest we head in the direction of descriptive variable names and limit the single letter variables as much as we can, if we look at the C++ style guide it has a section detailing best practices for naming: https://google.github.io/styleguide/cppguide.html#General_Naming_Rules > > For tests this is extra important, as the single letter variables make it harder to follow the logic of the test. For example, why is `A` the placeholder for `a` rather than defining `placeholder_a` and `array_a` to clarify that relationship? I agree with you in principle, however as it stands we do allow 'bad' variable names, however they are limited to a very small list which is fairly arbitrary. It seems to me it was basically made in order for the linter to pass. We can always restrict things later, but as it stands right now it provides an inconsistent policy which makes https://github.com/apache/tvm/issues/11414 a bit harder to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
