junrushao1994 commented on PR #12034: URL: https://github.com/apache/tvm/pull/12034#issuecomment-1178227041
> https://github.com/apache/tvm/blob/013d5e8fcbd94fb3a0c5c0cdcaea03af43c464aa/src/tir/op/op.cc#L514 > https://github.com/apache/tvm/blob/013d5e8fcbd94fb3a0c5c0cdcaea03af43c464aa/src/tir/op/op.cc#L102 I see. In this case, the most proper fix should be adding nullability checks in this method: ``` CHECK(lhs.defined()) << "ValueError: `lhs` is null in the binary operator"; CHECK(rhs.defined()) << "ValueError: `rhs` is null in the binary operator"; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
