junrushao1994 commented on PR #12034: URL: https://github.com/apache/tvm/pull/12034#issuecomment-1178252594
Thanks for your feedbacks! To share some history: TVM’s older infra didn’t differentiate really carefully for nullability, which leads to the issue that this PR is aiming to fix. The latest infra in TVM instead use “Optional” container and “not-nullable” marks to make sure nullability is explicitly checked by engineers. However, older code isn’t refactored to completely adopt such convention. In our particular case, empirically adding a check will not significantly impact performance, but I don’t have data either. If we really want to avoid throwing a segfault here, I would say its probably the best approach - other than completely refactoring the system to make PrimExpr not-nullable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
