mkatanbaf commented on code in PR #12125:
URL: https://github.com/apache/tvm/pull/12125#discussion_r929416081
##########
apps/microtvm/zephyr/template_project/src/host_driven/main.c:
##########
@@ -218,11 +303,42 @@ void uart_irq_cb(const struct device* dev, void*
user_data) {
}
}
+#ifdef FVP
Review Comment:
we are using the uart to write some log messages, and it might be a good
idea to initialize the fvp uart correctly. but technically we don't use the fvp
uart in RX mode, and it won't cause an error if we remove these lines (unless
someone accidentally sends data to the corresponding TCP port, which could
cause an overflow!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
