mehrdadh commented on code in PR #12125:
URL: https://github.com/apache/tvm/pull/12125#discussion_r939310189
##########
apps/microtvm/zephyr/template_project/microtvm_api_server.py:
##########
@@ -564,21 +599,49 @@ def generate_project(self, model_library_format_path,
standalone_crt_dir, projec
def build(self, options):
BUILD_DIR.mkdir()
- check_call(["cmake", ".."], cwd=BUILD_DIR)
+ zephyr_board = self._find_board_from_cmake_file()
Review Comment:
can you clarify why `cmake ..` and `make` doesn't work anymore?
##########
apps/microtvm/zephyr/template_project/src/host_driven/main.c:
##########
@@ -44,6 +43,12 @@
#include <unistd.h>
#include <zephyr.h>
+#ifdef FVP
+#include <irq.h>
+
Review Comment:
remove newline?
##########
apps/microtvm/zephyr/template_project/src/host_driven/semihost.h:
##########
@@ -0,0 +1,42 @@
+/*
Review Comment:
can you move fvp related files to a sub-directory like:
`apps/microtvm/zephyr/template_project/src/host_driven/fvp`
it would make it more readable.
Also using this style, we could also separate the zephyr transport files
from main.c and move it to a different sub directory . That could be for a
separate PR.
##########
tests/scripts/task_python_microtvm.sh:
##########
@@ -54,4 +55,4 @@ python3 gallery/how_to/work_with_microtvm/micro_tflite.py
python3 gallery/how_to/work_with_microtvm/micro_autotune.py
python3 gallery/how_to/work_with_microtvm/micro_aot.py
-run_pytest ctypes python-relay-strategy-arm_cpu
tests/python/relay/strategy/arm_cpu --enable-corstone300-tests
+run_pytest ctypes python-relay-strategy-arm_cpu
tests/python/relay/strategy/arm_cpu --enable-corstone300-tests
Review Comment:
add a new line. It's weird that CI didn't get an error here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
