gigiblender commented on code in PR #12178:
URL: https://github.com/apache/tvm/pull/12178#discussion_r930913205
##########
tests/scripts/task_cpp_unittest.sh:
##########
@@ -45,20 +45,23 @@ python3 tests/scripts/task_build.py \
--cmake-target cpptest \
--build-dir "${BUILD_DIR}"
-# crttest requires USE_MICRO to be enabled, which is currently the case
-# with all CI configs
-pushd "${BUILD_DIR}"
-ninja crttest
-popd
+# crttest requires USE_MICRO to be enabled.
+if grep -Fq "set(USE_MICRO ON)" ${BUILD_DIR}/config.cmake; then
Review Comment:
I went the route of separating the script into two
##########
tests/scripts/task_cpp_unittest.sh:
##########
@@ -45,20 +45,23 @@ python3 tests/scripts/task_build.py \
--cmake-target cpptest \
--build-dir "${BUILD_DIR}"
-# crttest requires USE_MICRO to be enabled, which is currently the case
-# with all CI configs
-pushd "${BUILD_DIR}"
-ninja crttest
-popd
+# crttest requires USE_MICRO to be enabled.
+if grep -Fq "set(USE_MICRO ON)" ${BUILD_DIR}/config.cmake; then
Review Comment:
I went the route of separating the script into two. Let me know your
thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
