driazati commented on code in PR #12178:
URL: https://github.com/apache/tvm/pull/12178#discussion_r931425116
##########
ci/jenkins/Test.groovy.j2:
##########
@@ -199,6 +217,9 @@ stage('Test') {
{{ method_name }}()
},
{% endfor %}
+ 'unittest: CPU MINIMAL': {
+ run_unittest_minimal()
+ },
Review Comment:
I still don't understand why we need a new macro, does this change not do
the same thing with existing code?
```suggestion
{% call m.test_step(
name="unittest: CPU MINIMAL",
node="CPU-SMALL",
ws="tvm/ut-python-cpu-minimal",
platform="minimal",
docker_image="ci_minimal",
) %}
{{ m.download_artifacts(tag='cpu-minimal', filenames=tvm_lib) }}
cpp_unittest(ci_minimal)
python_unittest(ci_minimal)
{% endcall %}
```
##########
tests/scripts/ci.py:
##########
@@ -595,11 +601,25 @@ def add_subparser(
"frontend": ("run frontend tests",
["./tests/scripts/task_python_frontend_cpu.sh"]),
},
),
+ generate_command(
+ name="minimal",
+ help="Run minimal CPU build and test(s)",
+ options={
+ "cpp": CPP_UNITTEST,
+ "unittest": (
+ "run unit tests",
+ [
+ "./tests/scripts/task_python_unittest.sh",
+ ],
+ ),
+ },
+ ),
generate_command(
name="i386",
help="Run i386 build and test(s)",
options={
"cpp": CPP_UNITTEST,
+ "micro_cpp": CPP_MICRO_UNITTEST,
Review Comment:
iirc these turn into command line flags
```suggestion
"micro-cpp": CPP_MICRO_UNITTEST,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
