junrushao1994 commented on code in PR #12101:
URL: https://github.com/apache/tvm/pull/12101#discussion_r931528838
##########
include/tvm/node/structural_equal.h:
##########
@@ -99,7 +125,10 @@ class StructuralEqual : public BaseValueEqual {
* equality checking. Instead, it can store the necessary equality conditions
* and check later via an internally managed stack.
*/
-class SEqualReducer : public BaseValueEqual {
+class SEqualReducer {
Review Comment:
Oh looks like we still depend on `BaseValueEqual`
[here](https://github.com/gbonik/tvm/blob/4c28f15da2268db5da587b87113dfc5288ef76a3/src/node/structural_equal.cc#L91-L92)...Then
I dont have strong opinions. Just let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
