junrushao1994 commented on code in PR #12101:
URL: https://github.com/apache/tvm/pull/12101#discussion_r931675308
##########
src/tir/analysis/deep_equal.cc:
##########
@@ -62,7 +67,7 @@ bool ExprDeepEqual::operator()(const PrimExpr& lhs, const
PrimExpr& rhs) const {
if (lhs.as<AnyNode>()) {
return false;
}
- return DeepCmpSEqualHandler().SEqualReduce(lhs, rhs, false);
+ return DeepCmpSEqualHandler().SEqualReduce(lhs, rhs, false, {});
Review Comment:
nit: prefer more explicit instantiation of `Optional<>`
```suggestion
return DeepCmpSEqualHandler().SEqualReduce(lhs, rhs, false, NullOpt);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
