driazati commented on code in PR #12332:
URL: https://github.com/apache/tvm/pull/12332#discussion_r940447731
##########
conftest.py:
##########
@@ -92,14 +92,11 @@ def pytest_collection_modifyitems(config, items):
shard_index = int(os.environ["TVM_SHARD_INDEX"])
print(f"Marking tests for shard {shard_index} of {num_shards}")
- for item in items:
+ items_copy = list(items)
+ for item in items_copy:
item_shard_index = find_shard_index(item.nodeid, num_shards=num_shards)
- item.add_marker(
- pytest.mark.skipif(
- item_shard_index != shard_index,
- reason=f"Test running on shard {item_shard_index} of
{num_shards}",
- )
- )
+ if item_shard_index != shard_index:
+ items.remove(item)
Review Comment:
The only hesitation I have with this is that now if someone goes and looks
for a test named `test_abc` in one of the 10 CPU integration shard logs, they'd
have to search through every log until they find it and more importantly know
that it's not weird that the test doesn't show up at all in most of the logs.
Do you have any ideas on how we could make this a better ux?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
