driazati commented on code in PR #12332:
URL: https://github.com/apache/tvm/pull/12332#discussion_r940548037
##########
conftest.py:
##########
@@ -92,14 +92,11 @@ def pytest_collection_modifyitems(config, items):
shard_index = int(os.environ["TVM_SHARD_INDEX"])
print(f"Marking tests for shard {shard_index} of {num_shards}")
- for item in items:
+ items_copy = list(items)
+ for item in items_copy:
item_shard_index = find_shard_index(item.nodeid, num_shards=num_shards)
- item.add_marker(
- pytest.mark.skipif(
- item_shard_index != shard_index,
- reason=f"Test running on shard {item_shard_index} of
{num_shards}",
- )
- )
+ if item_shard_index != shard_index:
+ items.remove(item)
Review Comment:
I see what you mean, I suppose it would be pretty rare. In a follow up or
something we can add a message that links to the log where all the steps are
catted together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
