jwfromm commented on code in PR #12342:
URL: https://github.com/apache/tvm/pull/12342#discussion_r940875918
##########
include/tvm/meta_schedule/space_generator.h:
##########
@@ -153,7 +153,7 @@ class SpaceGenerator : public runtime::ObjectRef {
* to blocks in post-DFS order.
* \return The design space generator created.
*/
- TVM_DLL static SpaceGenerator PostOrderApply();
+ TVM_DLL static SpaceGenerator PostOrderApply(runtime::PackedFunc
f_block_filter = nullptr);
Review Comment:
I think its a good idea to provide a default value for this function since
using a filter is an unusual case. Since this will mostly be called from python
it probably wont matter but just in case it's used from C++ this default will
be helpful. So we need to either set the default here or in
`post_order_apply.cc`. My understanding of good c++ hygiene is that defaults
should be set in headers when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
