zxybazh commented on code in PR #12342:
URL: https://github.com/apache/tvm/pull/12342#discussion_r940876627


##########
python/tvm/meta_schedule/space_generator/post_order_apply.py:
##########
@@ -29,8 +29,8 @@ class PostOrderApply(SpaceGenerator):
     rules to blocks in post-DFS order.
     """
 
-    def __init__(self):
+    def __init__(self, filter_fn=None):

Review Comment:
   Just to clarify, in previous cases we've been using f_func_name as 
PackedFunc argument name, for example in ApplyHistoryBest dispatch function. 
But I would be okay with using filter_fn here as long as it's consistent with 
c++ side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to