shingjan commented on code in PR #12618:
URL: https://github.com/apache/tvm/pull/12618#discussion_r956487421


##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -465,13 +465,13 @@ class uint64(PrimExpr):
     def __init__(self: uint64, imm: Union[PrimExpr, int]): ...
 
 class float8(PrimExpr):
-    def __init__(self: float8, imm: Union[PrimExpr, int, float]): ...
+    def __init__(self: float8, imm: Union[PrimExpr, int, float, str]): ...

Review Comment:
   right now tvm only requires python >= 3.6, which means `Literal` may not be 
available if python <3.8 is used. What about we put something like 
`SpecialFloatLiteral: str = str["inf", "-inf", "nan"]` until python>=3.8 is 
implemented in tvm?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to