vinx13 commented on code in PR #12618:
URL: https://github.com/apache/tvm/pull/12618#discussion_r956491763
##########
python/tvm/script/tir/__init__.pyi:
##########
@@ -464,14 +464,19 @@ class uint32(PrimExpr):
class uint64(PrimExpr):
def __init__(self: uint64, imm: Union[PrimExpr, int]): ...
+# use typing.Literal instead for python 3.8 or higher
+from typing_extensions import Literal
Review Comment:
I think it's be better to avoid extra dependency. We can check the sys
version and upgrade to 3.8 sometime in the future
```
if sys.version_info >= (3, 8):
SpecialFloatLiteral = ...
else:
SpecialFloatLiteral = str
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
