janetsc commented on code in PR #12727:
URL: https://github.com/apache/tvm/pull/12727#discussion_r966430790
##########
src/runtime/hexagon/hexagon_device_api.h:
##########
@@ -45,11 +45,27 @@ class HexagonDeviceAPI final : public DeviceAPI {
static HexagonDeviceAPI* Global();
//! \brief Constructor
- HexagonDeviceAPI() {}
+ HexagonDeviceAPI() { hexbuffs = std::make_unique<HexagonBufferManager>(); }
//! \brief Destructor
~HexagonDeviceAPI() {}
+ //! \brief Creates resource managers for the runtime
+ void AcquireResources() {
+ if (!hexbuffs->empty()) {
+ LOG(INFO) << "hexbuffs was not empty in AcquireResources";
Review Comment:
During my testing, I saw that there were allocations and frees before
AcquireResources was called. (During RPC initialization of this server).
Sometimes due to timing, there were still allocations at this point.
It is not the latter. I agree that we need a scheme for each user/client to
have its own resource manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
