billishyahao commented on PR #12787:
URL: https://github.com/apache/tvm/pull/12787#issuecomment-1247713331

   Thanks for the patch, Youlei! I found a bunch of statement like 
"op->dtype.is_float() || op->dtype.is_bfloat16()" in tvm folder
   
   Shall we simply add new float type definition in 
tvm/include/tvm/runtime/data_type.h to eliminate those statements?
   
   ```
     /*! \return whether type is a general float type, including 
float/float16/bfloat16. */
     bool is_general_float() const { return is_float() || is_bfloat16(); }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to