yangulei commented on PR #12787: URL: https://github.com/apache/tvm/pull/12787#issuecomment-1248794416
@billishyahao I agree that `is_general_float()` could make the code **cleaner**, but **not clearer**. `general float` is a broader concept rather than IEEE float point plus bfloat16, for example, `TensorFloat-32` is also a `general float`. I prefer to keep the expr like `op->dtype.is_float() || op->dtype.is_bfloat16()` as its more clear and specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
