janetsc commented on code in PR #12727: URL: https://github.com/apache/tvm/pull/12727#discussion_r973368886
########## src/runtime/hexagon/hexagon_device_api.cc: ########## @@ -90,18 +90,20 @@ void* HexagonDeviceAPI::AllocDataSpace(Device dev, int ndim, const int64_t* shap const size_t typesize = (dtype.bits / 8) * dtype.lanes; + HexagonBufferManager* mgr = runtime_hexbuffs ? runtime_hexbuffs.get() : &hexbuffs; Review Comment: I was keeping the check for both managers in free. However, now that I'm calling Acquire/Release in the session object directly, I can switch to having a "current" manager, and remove those trinary statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
