janetsc commented on code in PR #12727:
URL: https://github.com/apache/tvm/pull/12727#discussion_r972508664
##########
src/runtime/hexagon/hexagon_device_api.h:
##########
@@ -50,6 +50,25 @@ class HexagonDeviceAPI final : public DeviceAPI {
//! \brief Destructor
~HexagonDeviceAPI() {}
+ //! \brief Ensures resource managers are in a good state for the runtime
+ void AcquireResources() {
+ if (runtime_hexbuffs) {
+ LOG(INFO) << "runtime_hexbuffs has already been created";
Review Comment:
I considered this, but I didn't want it to register as an error, as we don't
enforce that all allocations are explicitly cleaned up. (Several tests hit
this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
