areusch commented on code in PR #12522:
URL: https://github.com/apache/tvm/pull/12522#discussion_r975599884
##########
python/tvm/driver/tvmc/autotuner.py:
##########
@@ -139,6 +138,11 @@ def add_tune_parser(subparsers, _, json_params):
help="enable tuning the graph through the AutoScheduler tuner",
action="store_true",
)
+ parser.add_argument(
+ "--visualize",
Review Comment:
i think the existing arg is okay, i agree it's a flag with two meanings, but
i think if you add it like this, the --help string will be clear:
```
NO_VISUALIZE_OPTION = object()
parser.add_argument("--visualize", nargs="?", type=str, metavar="file",
default=NO_VISUALIZE_OPTION, help="Visualize tuning progress. With no parameter
specified, display a pyplot window and update the graph as tuning progresses.
With a parameter, instead write the graph to the file specified (format
determined by the given file extension).")
```
(I think the "format determined by the given file extension" is correct, but
maybe double check that)
Alternatively open to the two options, especially if you think users want
both. you could also consider something like `--plot=live,foo.png`, which might
provide a nice set of flexibility without users needing to know two options and
how they interact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
