ashutosh-arm commented on code in PR #12950:
URL: https://github.com/apache/tvm/pull/12950#discussion_r984863090
##########
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc:
##########
@@ -133,6 +133,22 @@ class RelayToTIRVisitor : public MixedModeMutator {
} else {
conv2d_call = requantize_input;
}
+ int32_t dtype_bits =
conv2d_call->args[0]->type_as<TensorTypeNode>()->dtype.bits();
+
+ // Determine bitwidth of buffers based on input dtype
+ int32_t input_bits = 8;
+ int32_t filter_bits = 8;
+ int32_t bias_bits = 32;
+ int32_t output_bits = 8;
+ int32_t context_buffer_bits = 8;
+ bool is_int16 = false;
+ if (dtype_bits == 16) {
+ is_int16 = true;
+ input_bits = 16;
+ bias_bits = 64;
+ output_bits = 16;
+ context_buffer_bits = 16;
+ }
Review Comment:
Function is unreachable for other types because of two reasons: pattern
matching filters them out and the function is only called when a specific
function name is seen on the composite function. Still think a check is not
around dtypes? Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
