junrushao commented on code in PR #13050:
URL: https://github.com/apache/tvm/pull/13050#discussion_r995910678
##########
src/meta_schedule/database/json_database.cc:
##########
@@ -67,6 +68,10 @@ void JSONFileAppendLine(const String& path, const
std::string& line) {
/*! \brief The default database implementation, which mimics two database
tables with two files. */
class JSONDatabaseNode : public DatabaseNode {
public:
+ explicit JSONDatabaseNode(String mod_eq_name = "structural")
Review Comment:
just noticed that `DatabaseNode::mod_eq_` has been already a `unique_ptr` -
so we don't need an explicit default constructor `DatabaseNode::DatabaseNode`,
but instead we could do inline initialization:
```diff
- std::unique_ptr<ModuleEquality> mod_eq_;
+ std::unique_ptr<ModuleEquality> mod_eq_{nullptr};
```
BTW, just to nitpick, shall we change `mod_eq_` from `private` to
`protected` so it could be accessed by derived classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
