masahi commented on code in PR #13050:
URL: https://github.com/apache/tvm/pull/13050#discussion_r996067146
##########
src/meta_schedule/database/json_database.cc:
##########
@@ -67,6 +68,10 @@ void JSONFileAppendLine(const String& path, const
std::string& line) {
/*! \brief The default database implementation, which mimics two database
tables with two files. */
class JSONDatabaseNode : public DatabaseNode {
public:
+ explicit JSONDatabaseNode(String mod_eq_name = "structural")
Review Comment:
Since `JSONDatabaseNode` is constructed by `Database` class,
https://github.com/apache/tvm/blob/eecb7fd494052ca941f3d123daa2e887f14b7e75/src/meta_schedule/database/json_database.cc#L147-L150
and `Database` is not a subclass of `DatabaseNode`, setting `mod_eq` after
`JSONDatabaseNode` is constructed requires making `mod_eq` a public member or
introducing a setter method in `DatabaseNode`.
Moreover, it would also introduce complication to initializing
`workloads2idx_` (see
https://github.com/apache/tvm/pull/13050#discussion_r992887025).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
