vinx13 commented on code in PR #13085:
URL: https://github.com/apache/tvm/pull/13085#discussion_r997464102


##########
src/tir/ir/index_map.cc:
##########
@@ -147,6 +147,37 @@ IndexMap IndexMap::Inverse(Array<Range> initial_ranges) 
const {
   return inverse;
 }
 
+/*!
+ * \brief Evaluator to compute the mapped indices of a given index map.
+ */
+class IndexMapEvaluator : public DataTypeLegalizer {

Review Comment:
   It inherits from `DataTypeLegalizer` that contains extra logic than 
`StmtMutator`, I think it's better to be separated from `IRSubstitute`. Perhaps 
we can introduce another utility function `SubstituteWithDataTypePromotion`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to