Lunderberg commented on code in PR #13085:
URL: https://github.com/apache/tvm/pull/13085#discussion_r998217746
##########
src/tir/ir/index_map.cc:
##########
@@ -147,6 +147,37 @@ IndexMap IndexMap::Inverse(Array<Range> initial_ranges)
const {
return inverse;
}
+/*!
+ * \brief Evaluator to compute the mapped indices of a given index map.
+ */
+class IndexMapEvaluator : public DataTypeLegalizer {
Review Comment:
Hmm, good point. I had been thinking that the `DataTypeLegalizer` would
have the necessary follow-up steps that should be performed after every
substitution in order to have valid TIR, rather having extra logic as well.
Since there is extra logic, that would make sense to me to have the separate
`SubstituteWithDataTypeLegalization`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
