lhez commented on code in PR #13305:
URL: https://github.com/apache/tvm/pull/13305#discussion_r1015726385
##########
apps/cpp_rpc/CMakeLists.txt:
##########
@@ -32,6 +32,14 @@ if (OS)
endif()
endif()
+if(USE_OPENCL)
+ if (ANDROID_ABI)
+ if($ENV{ANDROID_NDK_MAJOR} VERSION_LESS "23")
Review Comment:
I guess this is the problem - `$ENV`.
I don't think `$ENV` is needed. The CMake toolchain file from NDK should
have already defined `ANDROID_NDK_MAJOR`. Hence, when that toolchain file is
specified, `ANDROID_NDK_MAJOR` can be directly used as `${ANDROID_NDK_MAJOR}`.
I think certain versions of CMake don't like `$ENV` being used with `if` and
`VERSION_LESS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
