echuraev commented on code in PR #13305:
URL: https://github.com/apache/tvm/pull/13305#discussion_r1016184545
##########
apps/cpp_rpc/CMakeLists.txt:
##########
@@ -32,6 +32,14 @@ if (OS)
endif()
endif()
+if(USE_OPENCL)
+ if (ANDROID_ABI)
+ if($ENV{ANDROID_NDK_MAJOR} VERSION_LESS "23")
+ set_property(TARGET tvm_rpc PROPERTY LINK_FLAGS -fuse-ld=gold)
Review Comment:
Yes, for me, it's the same: `libOpenCL.so` is not a part of the NDK. When I
build `tvm_rpc` with OpenCL support than I pass explicitly path to OpenCL SDK:
`-DUSE_OPENCL=<path/to/sdk>` and it works fine also with `ld`. As I have
mentioned in #13118, I checked that build works on many versions of NDK:
20.0.5594570, 21.3.6528147, 21.4.7075529, 22.1.7171670, etc. And I was
surprised that it doesn't work in the docker.
I'm curious why, in case of @srkreddy1238 `ld` cannot find the
`libOpenCL.so` but `ld.gold` can do it. In case then linkers have the same
paths, I would expect that they will work in the same way.
Anyway, I don't think that this discussion is a stopper for merging this PR.
But I'm just trying to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
