junrushao commented on code in PR #12496:
URL: https://github.com/apache/tvm/pull/12496#discussion_r1020621483
##########
python/tvm/tir/buffer.py:
##########
@@ -202,13 +200,14 @@ def __getitem__(self, indices):
expr_indices = []
for index in indices:
if isinstance(index, slice):
- lanes = analyzer.simplify(
- (index.stop - index.start + index.step - 1) //
index.step
- )
+ start = 0 if index.start is None else index.start
+ stop = self.shape[i] if index.stop is None else index.stop
+ step = 1 if index.step is None else index.step
Review Comment:
we do allow non-trivial step here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
