Lunderberg commented on PR #13438: URL: https://github.com/apache/tvm/pull/13438#issuecomment-1320760159
Oof, yeah, looks like that one becomes pretty heavily indented with `black`, with several sections starting at indentations around line 60-80. It looks like it is specifically the nested function calls (here the chain of `T.select`), each of which adds indentation. I think I'd still lean toward having the formatting enabled by default, since I think it improves readability on average, but it would be good to have a way to disable it when debugging cases where the readability is worsened. Maybe having the argument default be set by an environment variable, so that the formatting could be enabled/disabled across all calls as needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
