junrushao commented on PR #13438: URL: https://github.com/apache/tvm/pull/13438#issuecomment-1320830722
Some background: The reason that winograd conv2d has such a long chained `T.Select` is that it's used to represent A, B, G matrices, and by unrolling the corresponding loops in our scheduling, the `T.Select` is constant-folded into scalar constants. Therefore there is no performance degradation if scheduled properly. On sugaring long chained `T.Select`: The usecases of sugaring `T.Select`, if it's only limited to constant matrices in winograd conv, then it's probably less common and I would say it may not be desirable because it requires users to understand a new syntax. My two-cents: as long as we have a flag to turn it off, in `.show()` methods, I don't have a strong opinion if it defaults to on or off :-) Alternatively, when the IR is much longer (e.g. +20 extra lines after formatting), we could print out a doc, saying you may turn formatting off by tweaking the flag, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
