mkatanbaf commented on code in PR #13514:
URL: https://github.com/apache/tvm/pull/13514#discussion_r1060903615
##########
src/target/target_kind.cc:
##########
@@ -309,6 +309,7 @@ TVM_REGISTER_TARGET_KIND("c", kDLCPU)
.add_attr_option<String>("march")
.add_attr_option<Integer>("workspace-byte-alignment")
.add_attr_option<Integer>("constants-byte-alignment")
+ .add_attr_option<Integer>("num-cores")
Review Comment:
meta_schedule expects this attribute, see
https://github.com/apache/tvm/blob/main/src/meta_schedule/utils.h#L384
##########
src/target/source/codegen_c_host.cc:
##########
@@ -54,6 +54,7 @@ void CodeGenCHost::Init(bool output_ssa, bool emit_asserts,
bool emit_fwd_func_d
decl_stream << "#include \"tvm/runtime/c_runtime_api.h\"\n";
decl_stream << "#include \"tvm/runtime/c_backend_api.h\"\n";
decl_stream << "#include <math.h>\n";
+ decl_stream << "#include <stdbool.h>\n";
Review Comment:
some of the generated projects have a variable of type `bool`, and result in
build error if the `stdbool.h` header is not included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
