gromero commented on code in PR #13818: URL: https://github.com/apache/tvm/pull/13818#discussion_r1092307151
########## apps/microtvm/zephyr/template_project/launch_microtvm_api_server.sh: ########## @@ -0,0 +1,41 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +function show_usage() { + cat <<EOF +This script is for running microtvm_api_server. +Usage: launch_microtvm_api_server.sh <microtvm_api_server.py> --read-fd <READ_FD_PATH> --write-fd <WRITE_FD_PATH> +EOF +} + +if [ "$#" -lt 5 -o "$1" == "--help" ]; then + show_usage + exit -1 +fi + +west_file_path=$(which west) + +# Remove space and extra characters +line=$(head -n 1 ${west_file_path}) Review Comment: I see. So, a side effect now is that when `PYTHON_CMD` is set based on `which("python3.8")` if the user has no python3,8 installed in the env command like that use the Project API server, like `tvmc micro create-project`, will quite saying that `Error: Option 'west_cmd' is required but was not specified. Use --list-options to see all required options.`, which is misleading. Hence I wonder if the right env isolation should actually happen in the launcher, i.e the launcher would do the check for the right Python version -- 3.8 -- (and later the virtual env), whilst the Project API server would continue to use `sys.executable` to find out the west module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
