mehrdadh commented on code in PR #13818: URL: https://github.com/apache/tvm/pull/13818#discussion_r1092360636
########## apps/microtvm/arduino/template_project/launch_microtvm_api_server.sh: ########## @@ -0,0 +1,43 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +function show_usage() { + cat <<EOF +This script is for running microtvm_api_server. +Usage: launch_microtvm_api_server.sh <microtvm_api_server.py> --read-fd <READ_FD_PATH> --write-fd <WRITE_FD_PATH> +EOF +} + +if [ "$#" -lt 5 -o "$1" == "--help" ]; then + show_usage + exit -1 +fi + +ARDUINO_VENV_PATH=${HOME}/.tvm/micro_arduino Review Comment: This test file was fully based on importing the project api server to TVM which it doesn't work now because of dependencies. Also I checked with @guberti who wrote this test and it doesn't seem to be necessary to keep it anymore. ########## apps/microtvm/arduino/template_project/microtvm_api_server.py: ########## @@ -28,7 +28,7 @@ from string import Template from packaging import version -from tvm.micro.project_api import server +import server Review Comment: Yes, we are copying server.py as well to remove dependency of project api server to TVM. ########## apps/microtvm/zephyr/template_project/launch_microtvm_api_server.sh: ########## @@ -0,0 +1,41 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +function show_usage() { + cat <<EOF +This script is for running microtvm_api_server. +Usage: launch_microtvm_api_server.sh <microtvm_api_server.py> --read-fd <READ_FD_PATH> --write-fd <WRITE_FD_PATH> +EOF +} + +if [ "$#" -lt 5 -o "$1" == "--help" ]; then + show_usage + exit -1 +fi + +west_file_path=$(which west) + +# Remove space and extra characters +line=$(head -n 1 ${west_file_path}) Review Comment: `sys.executable` doesn't work since it will return tvm python env in docker. I think it should be python3.8 specifically and later we change it to use the python ENV that we use to setup Zephyr/west. Let me know what you think. ########## apps/microtvm/zephyr/template_project/launch_microtvm_api_server.sh: ########## @@ -0,0 +1,41 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +function show_usage() { + cat <<EOF +This script is for running microtvm_api_server with Zephyr. +Usage: launch_microtvm_api_server.sh <microtvm_api_server.py> --read-fd <READ_FD_PATH> --write-fd <WRITE_FD_PATH> +EOF +} + +if [ "$#" -lt 5 -o "$1" == "--help" ]; then + show_usage + exit -1 +fi + +west_file_path=$(which west) + +# Remove space and extra characters +line=$(head -n 1 ${west_file_path}) +line=$(echo ${line} | sed 's/ //') Review Comment: Let me try this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
