guberti commented on code in PR #13752:
URL: https://github.com/apache/tvm/pull/13752#discussion_r1101021878
##########
src/relay/transforms/simplify_expr.cc:
##########
@@ -979,7 +992,16 @@ Pass SimplifyExpr() {
return CreateFunctionPass(pass_func, 0, "SimplifyExpr", {"InferType"});
}
+Pass SimplifyExprPostAlterOp() {
+ runtime::TypedPackedFunc<Function(Function, IRModule, PassContext)>
pass_func =
+ [=](Function f, IRModule m, PassContext pc) {
+ return Downcast<Function>(SimplifyExprPostAlterOp(f, m));
+ };
+ return CreateFunctionPass(pass_func, 0, "SimplifyExprPostAlterOp",
{"InferType"});
+}
+
TVM_REGISTER_GLOBAL("relay._transform.SimplifyExpr").set_body_typed(SimplifyExpr);
+// Don't globally register SimplifyExprPostAlterOp
Review Comment:
You're right, we should register this as well. It doesn't seem useful
elsewhere, but it is weird to not register just this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
