mehrdadh commented on code in PR #13909: URL: https://github.com/apache/tvm/pull/13909#discussion_r1105111205
########## CMakeLists.txt: ########## @@ -264,6 +264,12 @@ else(MSVC) endif() endif(MSVC) +# USE_MICRO is on by default, but it is not needed for Hexagon builds nor will +# it function properly with USE_RPC disabled. +if(USE_HEXAGON OR NOT USE_RPC) + set(USE_MICRO OFF) Review Comment: I suggest for this case we just show an error and say this mode is not supported. changing the user specified configs silently is not ideal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
