alanmacd commented on code in PR #13909:
URL: https://github.com/apache/tvm/pull/13909#discussion_r1106519760
##########
cmake/modules/StandaloneCrt.cmake:
##########
@@ -15,41 +15,29 @@
# specific language governing permissions and limitations
# under the License.
-
if(USE_MICRO)
-if(MSVC)
-
- # When building for Windows, use standard CMake for compatibility with
- # Visual Studio build tools and not require Make to be on the system.
-
- # TODO: test building with this MSVC conditional code removed
- # when USE_MICRO is enabled
+ message(STATUS "Build microTVM RPC common")
- set(CRT_CONFIG, "src/runtime/micro/crt_config.h")
+ # add microTVM RPC common files to TVM runtime build
+ list(APPEND TVM_CRT_SOURCES
+ 3rdparty/libcrc/src/crcccitt.c
+ src/runtime/crt/microtvm_rpc_common/frame_buffer.cc
+ src/runtime/crt/microtvm_rpc_common/framing.cc
+ src/runtime/crt/microtvm_rpc_common/session.cc
+ src/runtime/crt/microtvm_rpc_common/write_stream.cc)
- add_library(host_standalone_crt
- STATIC
- 3rdparty/libcrc/src/crcccitt.c
- src/runtime/crt/microtvm_rpc_common/frame_buffer.cc
- src/runtime/crt/microtvm_rpc_common/framing.cc
- src/runtime/crt/microtvm_rpc_common/session.cc
- src/runtime/crt/microtvm_rpc_common/write_stream.cc)
+ list(APPEND RUNTIME_SRCS ${TVM_CRT_SOURCES})
+ include_directories(SYSTEM src/runtime/micro)
Review Comment:
it needs a header in that directory to build those files that are in
TVM_CRT_SOURCES, it's the same pattern used in other .cmake and CmakeLists.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
