lhutton1 commented on code in PR #13997:
URL: https://github.com/apache/tvm/pull/13997#discussion_r1111691912
##########
python/tvm/relay/op/contrib/ethosu.py:
##########
@@ -1375,6 +1375,82 @@ def mean_pattern() ->
tvm.relay.dataflow_pattern.DFPattern:
return pattern
+class SumParams:
+ """
+ This class will parse a call to ethosu.sum composite function
+ and extract the parameter information.
+ """
+
+ composite_name = "ethos-u.sum"
+
+ def __init__(self, func_body: Call):
+ from tvm.relay.backend.contrib.ethosu.util import RequantArgs
+
+ requantize = func_body
+ sum_op = requantize.args[0]
+ attrs = sum_op.attrs
+ cast = sum_op.args[0]
+
+ layout = "NHWC"
+ self.ifm = TensorParams(
+ cast.args[0],
+ layout,
+ requantize.args[RequantArgs.IFM_SCALE.value],
+ requantize.args[RequantArgs.IFM_ZERO_POINT.value],
+ )
+ self.ofm = TensorParams(
+ requantize,
+ layout,
+ requantize.args[RequantArgs.OFM_SCALE.value],
+ requantize.args[RequantArgs.OFM_ZERO_POINT.value],
+ )
+
+ ifm_shape = self.ifm.shape
+ self.height = ifm_shape[0] if len(ifm_shape) in (2, 3) else
ifm_shape[1]
+ self.width = ifm_shape[1] if len(ifm_shape) in (2, 3) else ifm_shape[2]
+ self.keepdims = attrs.keepdims
+
+ self.axis = list(sorted(attrs.axis))
+ if attrs.exclude:
+ self.axis = [i for i in range(len(self.ifm.shape)) if i not in
self.axis]
+
+ def is_valid(self) -> bool:
+ """
+ Checks whether Sum has compatible attributes with HW.
+ """
+
+ ifm_shape_len = len(self.ifm.shape)
+
+ if not check_valid_dtypes([self.ifm], [np.uint8, np.int8, np.int16,
np.int32]):
+ return False
+ if not check_valid_dtypes([self.ofm], [np.int8]):
Review Comment:
Thanks that makes sense, in this case it's likely better to use the ADD
operation instead since we can support more output data types - I'll double
check on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
