lhutton1 commented on code in PR #13997:
URL: https://github.com/apache/tvm/pull/13997#discussion_r1119056932
##########
python/tvm/relay/backend/contrib/ethosu/te/pooling.py:
##########
@@ -110,18 +110,21 @@ def pooling_compute(
padding = [int(v) for v in padding]
stride_h, stride_w = [int(v) for v in strides]
pool_shape_h, pool_shape_w = [int(v) for v in pool_shape]
+ ifm_channels = ofm_channels if pooling_type != "SUM" else ifm.shape[-1]
Review Comment:
Won't block on this as the functionality remains the same, but wondering if
`ofm_channels` ever made sense here and whether we can just use `ifm.shape[-1]`
for all pooling types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
