KJlaccHoeUM9l commented on code in PR #14018:
URL: https://github.com/apache/tvm/pull/14018#discussion_r1114190175
##########
python/tvm/topi/scatter_elements.py:
##########
@@ -127,9 +127,9 @@ def gen_ir(data_ptr, indices_ptr, updates_ptr, out_ptr):
elif reduction == "mul":
out[index2] *= updates[index1]
elif reduction == "min":
- tir.min(out[index2], updates[index1])
+ out[index2] = tir.min(out[index2], updates[index1])
elif reduction == "max":
- tir.max(out[index2], updates[index1])
+ out[index2] = tir.max(out[index2], updates[index1])
Review Comment:
Also [PR#14008](https://github.com/apache/tvm/pull/14008)?
##########
python/tvm/relay/frontend/pytorch.py:
##########
@@ -3785,6 +3836,8 @@ def create_convert_map(self):
"aten::nonzero": self.nonzero,
"aten::nonzero_numpy": self.nonzero_numpy,
"aten::scatter": self.scatter,
+ "aten::scatter_add": self.scatter_add,
Review Comment:
Looks like it's an artifact from
[PR#14008](https://github.com/apache/tvm/pull/14008)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
