vvchernov commented on code in PR #14018:
URL: https://github.com/apache/tvm/pull/14018#discussion_r1114673175
##########
python/tvm/topi/scatter_elements.py:
##########
@@ -127,9 +127,9 @@ def gen_ir(data_ptr, indices_ptr, updates_ptr, out_ptr):
elif reduction == "mul":
out[index2] *= updates[index1]
elif reduction == "min":
- tir.min(out[index2], updates[index1])
+ out[index2] = tir.min(out[index2], updates[index1])
elif reduction == "max":
- tir.max(out[index2], updates[index1])
+ out[index2] = tir.max(out[index2], updates[index1])
Review Comment:
Yes, but the problem was observed in this branch. After fix I repeated it on
#14008 side. I think the latter will be merged first and I update this PR with
mean reduction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
