quic-sanirudh commented on PR #14095: URL: https://github.com/apache/tvm/pull/14095#issuecomment-1441856005
> This effectively allows any index map. When the index map creates overlapping mapped indices, the correctness is not guaranteed. Hi, Apologies if I'm mistaken, but if correctness is not guaranteed, that would break the assumption most people would have, which is that no matter what scheduling we do, the actual computation is guaranteed. Could we perhaps add another argument to the `layout_transform` primitive to force implicit padding and set it to false by default so that by default implicit padding is disabled and we get an error on `None` for `pad_value`, but we can override that by setting an extra argument such as `sch.transform_layout(..., implicit_padding=True)`. I don't know if there are other schedule primitives that break the correctness assumption, so please correct me if I'm wrong about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
